Process-to-container mapping support for CRIO and Docker runtime#3
Open
manfuin wants to merge 1 commit intocnvrg:mainfrom
Open
Process-to-container mapping support for CRIO and Docker runtime#3manfuin wants to merge 1 commit intocnvrg:mainfrom
manfuin wants to merge 1 commit intocnvrg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial symptom, after deploying metaGPU, was no information about Pod processes.
After troubleshooting it is turned out the process-to-container mapping is not working. This comes down to the fact that "cgroup name equal to container id" is only true for containerd runtime.
Containers created by Docker or CRIO do have prefix and
.scopesuffix as well.This patch aims to recognize Docker/CRIO cgroup naming format and extract the ContianerId to make mapping happens.